twc/ludus
4
0
Fork 0
Code Issues 28 Pull Requests Packages Projects 8 Releases Wiki Activity

Unfuck mod in prelude #49

New Issue
Closed
opened 2024-05-23 20:54:07 +00:00 by scott · 4 comments
scott commented 2024-05-23 20:54:07 +00:00
Owner
Copy Link

mod (10, 5) & err=> "I don't know how to call nil"

Should: return 0

`mod (10, 5)` & err=> "I don't know how to call nil" Should: return 0
scott added the
bug
 label 2024-05-23 20:54:11 +00:00
scott added this to the Computer Class milestone 2024-05-23 20:54:15 +00:00
scott self-assigned this 2024-05-23 20:54:22 +00:00
scott added the
now
 label 2024-05-23 21:04:02 +00:00
scott commented 2024-05-23 23:30:19 +00:00
Author
Owner
Copy Link

As expected: current clj/s base does not include a member mod.

Fix this in the janet base before building.

As expected: current clj/s `base` does not include a member `mod`. Fix this in the janet base before building.
scott commented 2024-06-07 21:26:44 +00:00
Author
Owner
Copy Link

Done in 92a1ee9010

Turns out there was also an error with parameters and shadowing. Yay.

Done in https://alea.ludus.dev/twc/ludus/commit/92a1ee9010effa71c0bf652cd1c465ad395405c3 Turns out there was *also* an error with parameters and shadowing. Yay.
scott closed this issue 2024-06-07 21:26:44 +00:00
matt commented 2024-06-11 18:54:23 +00:00
Owner
Copy Link

@scott When I test the mod function it prints the arguments in the web console but doesn't return the result.

Try mod(3, 6) to see what's happening.

@scott When I test the `mod` function it prints the arguments in the web console but doesn't return the result. Try `mod(3, 6)` to see what's happening.
Screenshot 2024-06-11 at 2.53.57 PM.png
134 KiB
Screenshot 2024-06-11 at 2.53.57 PM.png
matt reopened this issue 2024-06-11 18:54:23 +00:00
scott commented 2024-06-11 21:26:54 +00:00
Author
Owner
Copy Link

@matt Thanks for this. It does return the result, but has the errant prints from debugging earlier. I've removed them from prelude in d7d9e71d67. When I do some additional debugging, I'll rebuild the things and push a new version to npm.

@matt Thanks for this. It *does* return the result, but has the errant `print`s from debugging earlier. I've removed them from prelude in https://alea.ludus.dev/twc/ludus/commit/d7d9e71d67cd253eece665df6768816dc985a588. When I do some additional debugging, I'll rebuild the things and push a new version to npm.
scott closed this issue 2024-06-11 21:26:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
accepted

A proposal has been accepted

  
bug

Something isn't working

  
clj

Related to the Clojure implementation

  
documentation

Improvements or additions to documentation

  
enhancement

New feature or request

  
errors

Language error reporting

  
infrastructure

Relates to hosting, git, tooling, etc.

  
later

To do someday

  
next

To do in a minute

  
now

To do now

  
optimization

Make things faster

  
proposal

A proposal to change the language

  
question

Further information is requested

  
research

An area of active research

  
semantics

Language behaviour

  
syntax

Syntactic forms

  
ux

Related to user experience

  
vm

Related to the bytecode VM

  
wontfix

This will not be worked on

No Label
accepted
bug
clj
documentation
enhancement
errors
infrastructure
later
next
now
optimization
proposal
question
research
semantics
syntax
ux
vm
wontfix
Milestone
Clear milestone
No items
No Milestone
Computer Class
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
scott
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: twc/ludus#49
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?