better_panics #15

scott · 2023-12-18T05:26:52Z

scott commented

2023-12-18 05:26:52 +00:00

Panic is now a form rather than a function: panic! {expr} instead of panic! (:msg). This allows the interpreter to attach a line number to panics.

Also, it doesn't make that much sense for it to be a function, since it stops the world.

Also also, this pull request fully fixes (I think) the bugs in line numbers with error reporting, whereby a panic is looking for a line number in the source of the script being executed, rather than in the script where the panic is found. Tokens now carry :source and :input fields that error.cljc plucks for reporting.

Panic is now a form rather than a function: `panic! {expr}` instead of `panic! (:msg)`. This allows the interpreter to attach a line number to panics. Also, it doesn't make that much sense for it to be a function, since it stops the world. Also also, this pull request fully fixes (I think) the bugs in line numbers with error reporting, whereby a panic is looking for a line number in the source of the script being executed, rather than in the script where the panic is found. Tokens now carry `:source` and `:input` fields that `error.cljc` plucks for reporting.

scott added 5 commits 2023-12-18 05:26:52 +00:00

Panic is now a form, not a function. 53b71fe790

Remove duplicate error messages. 4e646101e2

Fix line number reporting bugs: look for lines in the right place. be2c91b7dc

Stop tracking repl-port ff1e1345b8

Fix cljs/clj bug b12b49c197

scott merged commit 34f9a08bd6 into main

2023-12-18 05:26:58 +00:00

scott referenced this issue from a commit

2023-12-18 05:26:58 +00:00

Merge pull request 'better_panics' (#15) from better_panics into main

scott referenced this pull request